sketch out idea for ignoreGenerators, ignoreActions, ignoreFile#120
Closed
anithri wants to merge 6 commits intojondot:masterfrom
Closed
sketch out idea for ignoreGenerators, ignoreActions, ignoreFile#120anithri wants to merge 6 commits intojondot:masterfrom
anithri wants to merge 6 commits intojondot:masterfrom
Conversation
Whoaa512
reviewed
Jul 15, 2019
| /* wow, | ||
| this would need to be refactored into a different form | ||
| for ignoring generator actions files | ||
| */ |
Contributor
There was a problem hiding this comment.
@anithri Seems like you don't need to refactor completely. I think adding another filter before the internal prompt/index filter. Maybe adding a glob to regex library like globrex.
Then you wouldn't need ignore configuration for each type of thing, just ignore based on path.
Something like:
// user config
const config = {
userIgnores: [
'wip/**',
'utils.js'
]
}
// ...
const globrex = require('globrex');
const userIgnores = config.userIgnores.map(g => globrex(g))
// ...
.then(filter(f => !userIgnores.find(ig => ig.regex.test(f))))
Contributor
There was a problem hiding this comment.
Might make more sense to just forget the glob syntax and support plain regex
Draft
Contributor
Author
|
closing in favor of #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My biggest pain point has been trying to find the best ways to include static files, and have places to store code to be used in an actions
index.js.All I want is to be able to mark a directory as 'not an action', and a file as skipped.
The problem with this idea is having to figure out how to ignore the right things during the, um, interesting code that crawls the templates dir.