Skip to content

Deprecation Error by default #44

@splatEric

Description

@splatEric

I might be missing something horrendously obvious, but when I instantiate the client as laid out in the README, I get a deprecation notice, which in my environment is automatically an error.

Looking at the code, the mode parameter defaults to PHP_BINARY_READ and this mode immediately triggers the deprecation notice.

Would it be possible to release a version 4.x.x (to indicate a breaking change) that defaults to PHP_NORMAL_READ.

If not, perhaps it would be worth highlighting in the README? Happy to do a PR for either option ...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions