fixed serialisation issues for the LinkedIn#333
fixed serialisation issues for the LinkedIn#333gkovbasenko wants to merge 3 commits intojoscha:2.4.xfrom
Conversation
gkovbasenko
commented
Feb 20, 2017
- Added additional parent for the SerializableRequestToken, that would allow us to have non-parameters constructor.
- Changed loading from the cache.
|
I don't fully understand why this change is needed, can you elaborate, please? Also, I don't think we should log the secret out. |
|
Hi, I have done this changes, since even after adding default constructor for the RequestToken, I keep getting error: [error] m.plugin - An error has occured while getting the value from memcached. ct=Any So I have added additional class, which is non-Serialazable with empty constructor. After this I have got an error that class is serialazable, but contains empty details. That's why I load from the cache SerializableRequestToken instead of RequestToken. After all these changes, login with LinkedId account on our system was successful. I might miss to remove logs. Let me check and push code without them. |