Index hash_key values were empty because of the key used.#124
Merged
loganb merged 2 commits intojoshsymonds:masterfrom Jun 16, 2013
Merged
Index hash_key values were empty because of the key used.#124loganb merged 2 commits intojoshsymonds:masterfrom
loganb merged 2 commits intojoshsymonds:masterfrom
Conversation
Contributor
Author
|
OK.. Writing the spec for this I find out that the problem was not the one I described above but the fact that sometimes hashes were using strings and sometimes symbols. I will commit shortly the correct fix + the spec for it. |
Collaborator
|
Great catch! |
loganb
added a commit
that referenced
this pull request
Jun 16, 2013
Symbolize keys passed to Chain#where()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index hash_key values were empty because of the key used. This was happening when the key used was email. I am not sure if it was because of @ or . character from the key value..