add custom createTransitionString function#239
Open
j3l11234 wants to merge 4 commits intojoshwcomeau:masterfrom
Open
add custom createTransitionString function#239j3l11234 wants to merge 4 commits intojoshwcomeau:masterfrom
j3l11234 wants to merge 4 commits intojoshwcomeau:masterfrom
Conversation
Owner
|
hi @j3l11234, Sorry I never addressed this. This project has been on the back burner for me, in a totally different kitchen. I'm not looking to add any more features to this repo, I don't have time to maintain it as-is. Glad that you've found functionality that is useful though! I'll leave this PR open so others can discover it / use your fork if they also need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my case I want to add background-color transition.
I think customization the createTransitionString function is a good way, Because we may add other transition.
{ transition: transform 500ms ease-in-out 0ms, opacity 500ms ease-in-out 0ms, background-color 500ms ease-in-out 2000ms; }