Skip to content
This repository was archived by the owner on Apr 24, 2025. It is now read-only.

Conversation

@ilovelinux
Copy link
Contributor

Proposed Changes

Since ask-cli 2.30.0 introduces a breaking change (see alexa/ask-cli#485), I edited accordingly the headers parsing function.

I also dropped support for ask-cli 2.29.2 and older.

Fixes #1568, jovotech/jovo-cli#357
Closes #1575 (not working)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • The code has been tested

@aswetlow aswetlow requested review from aswetlow and jankoenig August 8, 2023 13:04
@aswetlow
Copy link
Member

aswetlow commented Aug 8, 2023

Thank you @ilovelinux

@jankoenig jankoenig changed the base branch from v4/latest to v4/dev August 8, 2023 13:52
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aswetlow aswetlow merged commit 174e807 into jovotech:v4/dev Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploying to Alexa fails with headers.find is not a function

3 participants