feat(git): enhance diff handling based on configuration#16
Merged
jsburckhardt merged 1 commit intomainfrom Oct 24, 2024
Merged
Conversation
Refactor the diff retrieval logic to use a unified function `GetGitDiff` that determines whether to get the diff from the main branch or the staged changes based on the configuration's `PR` flag. Additionally, update the `Config` structure to include the `PR` field for managing this behavior. BREAKING CHANGE: Changes the `Commit` function by removing the `pr` parameter. Now, the function relies solely on the `ShouldCommit` and `PR` fields in the configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the diff retrieval logic to use a unified function
GetGitDiffthat determines whether to get the diff from the main branch or the staged changes based on the configuration'sPRflag. Additionally, update theConfigstructure to include thePRfield for managing this behavior.BREAKING CHANGE: Changes the
Commitfunction by removing theprparameter. Now, the function relies solely on theShouldCommitandPRfields in the configuration.