Allow emoji characters as well-formed XML #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved jsdom/jsdom#3461 .
https://github.com/jsdom/w3c-xmlserializer/blob/master/lib/serialize.js#L151
w3c-xmlserializer checks the given XML node is well-formed.
Emoji characters (such as 🔍) are not matched to
XML_CHARregular expression.But, Emoji characters are allowed in well-formed XML according to the W3C specification.
https://github.com/jsdom/w3c-xmlserializer/blob/master/lib/serialize.js#L8
XML_CHARis defined as/^(\x09|\x0A|\x0D|[\x20-\uD7FF]|[\uE000-\uFFFD]|(?:[\uD800-\uDBFF][\uDC00-\uDFFF]))*$/uBecause this regular expression uses
uoption, surrogate pair (such as emoji) is not matched.Surrogate pair is matched by adding
[\u{10000}-\u{10FFFF}]range.