Skip to content

Fix CI GH action #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UlisesGascon merged 3 commits into from
Apr 9, 2024
Merged

Fix CI GH action #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d340db
pin nyc versions for node 8 & 9 and fix npm config
carpasse Apr 9, 2024
f1799d7
remove node version 0.6 from ci gh action. It won't build on ubuntu 20
carpasse Apr 9, 2024
53c9da5
add missing node versions to ci action
carpasse Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ on:

jobs:
test:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
strategy:
matrix:
name:
- Node.js 0.6
- Node.js 0.8
- Node.js 0.10
- Node.js 0.12
Expand All @@ -31,13 +30,12 @@ jobs:
- Node.js 15.x
- Node.js 16.x
- Node.js 17.x
- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x

include:
- name: Node.js 0.6
node-version: "0.6"
npm-i: mocha@1.21.5
npm-rm: nyc

- name: Node.js 0.8
node-version: "0.8"
npm-i: mocha@2.5.3
Expand Down Expand Up @@ -73,19 +71,19 @@ jobs:

- name: Node.js 6.x
node-version: "6.17"
npm-i: mocha@6.2.2 nyc@14.1.1
npm-i: mocha@6.2.3 nyc@14.1.1

- name: Node.js 7.x
node-version: "7.10"
npm-i: mocha@6.2.2 nyc@14.1.1
npm-i: mocha@6.2.3 nyc@14.1.1

- name: Node.js 8.x
node-version: "8.17"
npm-i: mocha@7.2.0
npm-i: mocha@7.2.0 nyc@14.1.1

- name: Node.js 9.x
node-version: "9.11"
npm-i: mocha@7.2.0
npm-i: mocha@7.2.0 nyc@14.1.1

- name: Node.js 10.x
node-version: "10.24"
Expand All @@ -108,11 +106,23 @@ jobs:
node-version: "15.14"

- name: Node.js 16.x
node-version: "16.14"
node-version: "16.13"

- name: Node.js 17.x
node-version: "17.4"

- name: Node.js 18.x
node-version: "18.20"

- name: Node.js 19.x
node-version: "19.9"

- name: Node.js 20.x
node-version: "20.12"

- name: Node.js 21.x
node-version: "21.7"

steps:
- uses: actions/checkout@v2

Expand All @@ -139,7 +149,15 @@ jobs:
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"

- name: Configure npm
run: npm config set shrinkwrap false
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi

- name: Remove non-test npm modules
run: npm rm --silent --save-dev csv-parse raw-body stream-to-array

- name: Remove npm module(s) ${{ matrix.npm-rm }}
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
Expand Down Expand Up @@ -190,7 +208,7 @@ jobs:
uses: coverallsapp/github-action@master
if: steps.list_env.outputs.nyc != ''
with:
github-token: ${{ secrets.github_token }}
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ matrix.test_number }}
parallel: true

Expand All @@ -201,5 +219,5 @@ jobs:
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true