Skip to content

Python updated to 3.6 and add Dockerfile installation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andsfonseca wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Python updated to 3.6 and add Dockerfile installation #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d0424b
feat: changes on cmakelist
andsfonseca Nov 27, 2020
eb539bf
feat: NUMPY_IMPORT_ARRAY_RETVAL returns null
andsfonseca Nov 27, 2020
8618040
feat: readme.md Update
andsfonseca Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ else()
message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} has no C++11 support. Please use a different C++ compiler.")
endif()

find_package(PythonLibs 3.5 REQUIRED)
find_package(PythonLibs 3.6 REQUIRED)
find_package(NumPy)
find_package(Boost 1.45.0 REQUIRED COMPONENTS python-py35)
find_package(Boost 1.65.1 REQUIRED COMPONENTS python-py36)
find_package(OpenCV REQUIRED)
find_package(ORB_SLAM2 REQUIRED)
find_package(Pangolin)
Expand Down Expand Up @@ -69,5 +69,5 @@ if (Pangolin_FOUND)
target_link_libraries(${TARGET_MODULE_NAME} ${Pangolin_LIBRARIES})
endif()

install(TARGETS ${TARGET_MODULE_NAME} DESTINATION lib/python3.5/dist-packages)
install(TARGETS ${TARGET_MODULE_NAME} DESTINATION lib/python3.6/dist-packages)

5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ A python wrapper for ORB_SLAM2, which can be found at [https://github.com/raulmu
This is designed to work with the base version of ORB_SLAM2, with a couple of minimal API changes to access the system output.
It has been tested on ubuntu 14.04 and 16.04 and built against Python3, although it does not rely on any python3 features.

## Installation (Dockerfile)

This dockfile sets up an environment for building and running ORBSLAM2 with Python 3.6 on Ubuntu 18.04.
You can use from this link: [https://hub.docker.com/r/andsfonseca/orbslam2_python](https://hub.docker.com/r/andsfonseca/orbslam2_python)

## Installation

### Prerequesities
Expand Down
3 changes: 2 additions & 1 deletion src/ORBSlamPython.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ static void init_ar() {
Py_Initialize();

import_array();
return NUMPY_IMPORT_ARRAY_RETVAL;
// return NUMPY_IMPORT_ARRAY_RETVAL;
return NULL;
}

BOOST_PYTHON_MODULE(orbslam2)
Expand Down