fix: add missing boolean mount flags to fix --flag=value error#59
fix: add missing boolean mount flags to fix --flag=value error#59yujunz wants to merge 1 commit intojuicedata:masterfrom
Conversation
|
Is that AI code ? |
|
Yes, it is generated by claude given the issue as context. It seems getting the flags from document and What is supposed to be the source of truth for latest flags? |
|
@yujunz, using AI to generate code for core logic like mount flags without verifying it against the actual source code is problematic. Even if you used You should refrain from submitting AI-generated guesses. If you want to contribute, you must manually cross-reference the flags with the actual codebase to ensure they are handled correctly. |
Good point. Please take another look after cross check (by AI 😊)
Would you mind contributing to review the change? |
|
That's better but honestly I ditched the Docker plugin in favor of a systemd unit service for now since I had other issues. For example if I want to reuse the same volume 4 times on different services, it mounts the volume 4 times (4 juiceFS processes with each one consuming its own RAM for caching). I wanted to use --all-squash 1000:1000 as well and it was not supported. I will open new issues to reflect the different problems I encountered and I would happily test it later. The big problem with the docker volume plugin in its current state is that it won't translate the mount flags very well and the So it would be probably better to allow another way to pass flags (for example a mountFlags attribute string which would be entirely passed to the mount command). The problem you will have with the current method is that you will have to maintain the flags on each juiceFS release which can add flag parameters. Before : After : |
Add formatFlags, authFlags, and mountFlags options to pass raw flags directly to JuiceFS commands without plugin-level parsing. This allows: - Using any JuiceFS flag (e.g., --all-squash 1000:1000) - Avoiding maintenance burden of tracking JuiceFS flag changes - Full flexibility for advanced users Example: -o mountFlags="--all-squash 1000:1000 --cache-size 10G" Also includes unit tests for flag building logic. Co-Authored-By: Claude (aws/anthropic/claude-opus-4-5) <noreply@anthropic.com>
Expand the mountFlags whitelist in both ceMount and eeMount functions to include all boolean flags from the JuiceFS mount command. This fixes the issue where boolean flags like --no-bgjob were incorrectly passed as --no-bgjob=true, causing JuiceFS to fail with "unknown option" error.
Fixes #58