Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 80.10% 82.01% +1.90%
==========================================
Files 3 3
Lines 372 378 +6
==========================================
+ Hits 298 310 +12
+ Misses 74 68 -6
☔ View full report in Codecov by Sentry. |
|
cc @matbesancon there are a bunch of solvers like this that had slightly varying implementations of TimeLimitSec. This PR is arguably a bug fix, but it is potentially breaking in that querying TimeLimitSec will now return |
|
I would say that's fine. There are always problems with getting unset attribute values, because it often requires the wrapper to store what has been set or not, which is quite cumbersome. |
x-ref jump-dev/MathOptInterface.jl#2256