Make xeus static/shared build user configurable for linking#19
Make xeus static/shared build user configurable for linking#19anutosh491 wants to merge 6 commits intojupyter-xeus:mainfrom
Conversation
|
Ahh the failure is because we have this Lines 29 to 41 in eceb40c And although we merged the PR on xeus, there hasn't been a release there and hence this can't fetch it ! P.S: Was there some reason why we don't use an env but use a dockerfile for testing here ? |
Since you do |
This would validate making a xeus release. |
81d3062 to
2daa288
Compare
|
The test kernel complains about libxeus.so not being there. It is not picked up by the Shouldn't libxeus' shared object have a different extension in the WebAssembly case? |
Hmm, Yes I think it needs to be in the same location as the test_xx.js/wasm files |
|
Hmm still fails, not sure what I miss : |
7b1ecc1 to
2daa288
Compare
|
I see this error on the 3.1.73 CI Not sure where this LinkError comes from cause I am able to run the tests locally with 3.1.73 without any issues |
|
Maybe @DerThorsten knows what changes between emscripten 3.1 and 4.0 that could trigger this issue. |
hmm locally emscripten 3.1.73 and node 16 does the job for me ! |
|
using #20 |
As we now provide a shared and a static build for xeus through emscripten-forge, this can be made user configurable.
I've used the shared build for xeus by default through
XEUS_LITE_USE_SHARED_XEUS