Skip to content

Added support for section (slide) "data-*" attributes#1861

Merged
blink1073 merged 6 commits intojupyter:mainfrom
bouzidanas:Working
Sep 12, 2022
Merged

Added support for section (slide) "data-*" attributes#1861
blink1073 merged 6 commits intojupyter:mainfrom
bouzidanas:Working

Conversation

@bouzidanas
Copy link
Copy Markdown
Contributor

@bouzidanas bouzidanas commented Sep 7, 2022

Feature: Add <section> tag metadata ( data-* ) attributes by adding a new notebook cell metadata attribute called "data" inside the slideshow attribute:

{
    "id": "QhrtDbohUhIF",
    "slideshow": {
        "slide_type": "slide",
        "data": {
          "background_video": "video_url.mp4",
          "background_video_loop": "",
          "background_video_muted": ""
        }
    }
}

@bouzidanas bouzidanas changed the title Working added ability to set slide "data-*" attribute Sep 8, 2022
@bouzidanas bouzidanas changed the title added ability to set slide "data-*" attribute added ability to set slide/section "data-*" attributes Sep 8, 2022
@bouzidanas bouzidanas changed the title added ability to set slide/section "data-*" attributes Added ability to set slide/section "data-*" attributes Sep 8, 2022
Copy link
Copy Markdown
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@blink1073 blink1073 merged commit e618f91 into jupyter:main Sep 12, 2022
@bouzidanas bouzidanas changed the title Added ability to set slide/section "data-*" attributes Added support for section (slide) "data-*" attributes Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants