Add strip_invalid_metadata argument to validator normalize method#355
Merged
blink1073 merged 1 commit intojupyter:mainfrom Mar 19, 2023
Merged
Add strip_invalid_metadata argument to validator normalize method#355blink1073 merged 1 commit intojupyter:mainfrom
blink1073 merged 1 commit intojupyter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 This update adds the
strip_invalid_metadataargument to the publicnormalizemethod, passing the argument into the nonpublic_normalizemethod rather than always passing false.The reason behind this change is that the _normalize method only uses the
relax_add_propsargument whenstrip_invalid_metadatais true. That argument is currently hardcoded to false bynormalize, making therelax_add_propsargument functionality unused. By allowing callers to specifystrip_invalid_metadata, there is at least a chance that therelax_add_propargument will also be used.I didn't see any tests in this project related to the normalize method, so I wasn't sure what might be needed for tests.