Diffing does not work

[krassowski]

Description

Clicking on "diff" button in the panel does nothing for me. Nor does selecting diff from context menu. This happens on both files and notebooks. There is no error message. Other buttons (open/discard/stage) work well. Clicking nbdime git button shows me a diff correctly.

If it works for you maybe it is a transitive problem on my machine, but in that case error propagation is off.

Context

0.50.0rc0

[fcollonval]

I don't have any issue. If you have the chance to try again that will be great.

[krassowski]

I still see this issue, both locally and on binder. Here is the gist: https://gist.github.com/krassowski/847732eb6c16e168fb4c0b16d9706142

Tested with both JupyterLab 4.0.9 and 4.1.0a3 in Chrome 119.0.6045.105 and Firefox 119.0.1. Happens with both files and notebooks.

[krassowski]

This is not UI issue as the command gets invoked. The problem appears to be that pathRepository is an empty string:

.

However, elsewhere pathRepository is compared against null not just for whether it is truthy. You may not see the issue if your root dir is different from git repo dir.

[krassowski]

This is good:

jupyterlab-git/src/commandsAndMenu.tsx

Lines 293 to 295 in d152a60

	isEnabled: () => gitModel.pathRepository !== null,
	execute: () => {
	if (gitModel.pathRepository === null) {

This is the wrong code IMO:

jupyterlab-git/src/commandsAndMenu.tsx

Lines 1279 to 1281 in d152a60

	if (!gitModel.pathRepository) {
	return;
	}

This may be bad too:

jupyterlab-git/src/model.ts

Lines 363 to 365 in d152a60

	if (!this.pathRepository) {
	return new BranchMarker(() => {});
	}

[fcollonval]

Thanks for investigating this one more. Indeed I missed it because I almost never run it at within a repository to test different test repositories locally. I'll push a fix.