Skip to content

Add confirmation dialog when checking out remote branch#1366

Merged
jtpio merged 1 commit intojupyterlab:mainfrom
gjmooney:remote_checkout_confirmation
Oct 25, 2024
Merged

Add confirmation dialog when checking out remote branch#1366
jtpio merged 1 commit intojupyterlab:mainfrom
gjmooney:remote_checkout_confirmation

Conversation

@gjmooney
Copy link
Contributor

Addresses #1352.

Based on @jtpio's suggestion I added a confirmation dialog when checking out a remote branch that could potentially cause a loss of changes on a users local branch.

confirm_checkout

@github-actions
Copy link

Binder 👈 Launch a Binder on branch gjmooney/jupyterlab-git/remote_checkout_confirmation

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Oct 25, 2024

Wondering if it could be worth reconsidering the use of the -B flag for the git checkout command? To be able to have a similar workflow as when using the git command directly (detached mode, and no commit lost).

Something we could track in a separate issue, as it may require more work and would likely change the current behavior, as discussed in #1352.

@jtpio
Copy link
Member

jtpio commented Oct 25, 2024

Something we could track in a separate issue

Opened #1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants