Add environment variable inheritance to git status and branch API calls#1417
Open
nsingl00 wants to merge 3 commits intojupyterlab:mainfrom
Open
Add environment variable inheritance to git status and branch API calls#1417nsingl00 wants to merge 3 commits intojupyterlab:mainfrom
nsingl00 wants to merge 3 commits intojupyterlab:mainfrom
Conversation
|
|
krassowski
approved these changes
Aug 27, 2025
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
In general the pattern we use in the codebase is:
env = os.environ.copy()
env["GIT_TERMINAL_PROMPT"] = "0"but I think these commands should not prompt so I think it is fine to merge as-is.
Member
|
Looks like CI is failing due to a lint issue: 
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several git subprocess calls in the status and branch APIs were not inheriting the parent process environment variables, which could cause git commands to fail when custom environment configurations are needed (e.g., custom PATH, GIT_*
variables, proxy settings, or authentication tokens).
Added env=os.environ.copy() parameter to the following subprocess calls:
Issue: #1416