Merged
Conversation
pkufool
added
ready
danpovey
reviewed
May 22, 2023
| (T_ + t - prune_num_frames) > 0 ? (T_ + t - prune_num_frames) : 0; | ||
| int32_t prune_t_end = T_ + t; | ||
| PruneTimeRange(prune_t_begin, prune_t_end); | ||
| if (t == b_fsas_->shape.MaxSize(1)) { |
Collaborator
There was a problem hiding this comment.
@pkufool I'm just curious about this change here, was it to fix some kind of bug?
I think the goal here with the periodic pruning was to reduce memory consumption, but it's not impossible that the implementation could have been buggy (or unnecessary in practice).
Collaborator
Author
There was a problem hiding this comment.
For streaming decoding, we will invoke this function every chunk, so I think we only need to prune once for each chunk, this fix is for efficiency.
[edit] This PR is not the fixes for the bug #1194 , I have not fixed it yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.