Fix nil pointer panic when schedule has no ScheduleCommon#1155
Open
Fix nil pointer panic when schedule has no ScheduleCommon#1155
Conversation
3 tasks
tobru
approved these changes
Mar 23, 2026
Contributor
|
@Kidswiss mind giving this a review? I think it's OK, but I need another eye. |
arska
force-pushed
the
fix/nil-schedule-crash-1041
branch
from
1f5c83c to
297b9b2
Compare
bastjan
reviewed
Mar 23, 2026
Member
Author
|
Applied the suggestion across all 5 schedule types — using |
Member
Author
|
@bastjan, golangci-lint disagrees. Should we go back or change linter settings? |
Member
|
I tend to prefer code clarity over "nice to have" lints. |
arska
added
the
discussion-needed
arska
force-pushed
the
fix/nil-schedule-crash-1041
branch
from
63ff5f9 to
2de4eca
Compare
When a Schedule resource specifies a job type (e.g. backup:) with fields but omits the schedule: field, the embedded *ScheduleCommon pointer is nil. Calling GetSchedule() on it caused a nil pointer dereference crash. Add nil checks to GetSchedule() for all five schedule types: BackupSchedule, RestoreSchedule, ArchiveSchedule, CheckSchedule, and PruneSchedule. Fixes #1041 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Use in.ScheduleCommon.Schedule instead of in.Schedule to make it clear the field comes from the embedded pointer, and why the nil check is needed. Suggested-by: @bastjan Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
arska
force-pushed
the
fix/nil-schedule-crash-1041
branch
from
2de4eca to
389f11f
Compare
Disable staticcheck QF1008 ("could remove embedded field from
selector") to allow using in.ScheduleCommon.Schedule instead of
in.Schedule. The explicit form makes it clear why the nil check
is needed — the Schedule field comes from an embedded pointer.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
Member
Author
|
Added a lint exclusion for QF1008 in |
Kidswiss
requested changes
Mar 27, 2026
Contributor
Kidswiss
left a comment
Kidswiss
left a comment
There was a problem hiding this comment.
I propose to mark the SchedulerCommon.Schedule as required in addition. IMHO doesn't make much sense to specify a schedule and then NOT adding the actual schedule.
Since the parent fields are optional, this will result in a conditional require.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backup:) with fields but omits theschedule:field*ScheduleCommonpointer is nil in this case, causingGetSchedule()to panicGetSchedule()for all five schedule typesFixes #1041
Test plan
ScheduleCommonapi/v1tests still pass🤖 Generated with Claude Code