Skip to content

fix(#1189): Unset BACKUP_PROMURL when not explitly set in helm values#1191

Open
lukasdietrich wants to merge 2 commits intok8up-io:masterfrom
lukasdietrich:fix/1189/unset-default-prom-url
Open

fix(#1189): Unset BACKUP_PROMURL when not explitly set in helm values#1191
lukasdietrich wants to merge 2 commits intok8up-io:masterfrom
lukasdietrich:fix/1189/unset-default-prom-url

Conversation

@lukasdietrich
Copy link
Copy Markdown

Summary

This pr unsets the global default prometheus url on the operator (BACKUP_PROMURL), unless it is explicitly set in the helm values.

Unless there was a reason for the default of https://127.0.0.1/, this should not be a breaking change.

I created this pr to address #1189.

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Commits are signed off
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

…lm values

Signed-off-by: Lukas Dietrich <lukas@lukasdietrich.com>
@lukasdietrich lukasdietrich requested a review from a team as a code owner March 27, 2026 20:15
@lukasdietrich lukasdietrich requested review from bastjan and tobru and removed request for a team March 27, 2026 20:15
Signed-off-by: Lukas Dietrich <lukas@lukasdietrich.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant