fix(#1189): Unset BACKUP_PROMURL when not explitly set in helm values#1191
Open
lukasdietrich wants to merge 2 commits intok8up-io:masterfrom
Open
fix(#1189): Unset BACKUP_PROMURL when not explitly set in helm values#1191lukasdietrich wants to merge 2 commits intok8up-io:masterfrom
BACKUP_PROMURL when not explitly set in helm values#1191lukasdietrich wants to merge 2 commits intok8up-io:masterfrom
Conversation
…lm values Signed-off-by: Lukas Dietrich <lukas@lukasdietrich.com>
Signed-off-by: Lukas Dietrich <lukas@lukasdietrich.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr unsets the global default prometheus url on the operator (
BACKUP_PROMURL), unless it is explicitly set in the helm values.Unless there was a reason for the default of
https://127.0.0.1/, this should not be a breaking change.I created this pr to address #1189.
Checklist
For Helm Chart changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:chartchart:k8upmake chart-docs