Use hex escape sequences instead of octal escape sequences#291
Open
Mingun wants to merge 1 commit intokaitai-io:masterfrom
Open
Use hex escape sequences instead of octal escape sequences#291Mingun wants to merge 1 commit intokaitai-io:masterfrom
Mingun wants to merge 1 commit intokaitai-io:masterfrom
Conversation
Mingun
force-pushed
the
hex-escape-seq
branch
2 times, most recently
from
e2f65df to
8fcc010
Compare
Contributor
Author
|
This is ready for review. |
Comment on lines
30
to
31
|
|
||
| /** octal escapes (which [[translators.CommonLiterals.strLiteralGenericCC]] uses by default) are not allowed in JSON */ | ||
| override def strLiteralGenericCC(code: Char): String = strLiteralUnicode(code) |
Member
There was a problem hiding this comment.
This comment should be updated, not deleted. The fact that we're overriding strLiteralGenericCC at all still deserves an explanation. Nothing has changed about that, because JSON allows neither octal nor hex escapes.
Contributor
Author
There was a problem hiding this comment.
Returned back with "hex escapes"
Mingun
force-pushed
the
hex-escape-seq
branch
from
ad457a3 to
8233841
Compare
Mingun
force-pushed
the
hex-escape-seq
branch
2 times, most recently
from
81600d2 to
2a5c7d2
Compare
Octal escape sequences the least used form of escape sequences and hex supported everywhere. The only outsiders are Java, C++ and Rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Octal escape sequences the least used form of escape sequences and hex supported almost everywhere. The only outsiders are Java (does not support
\xHHform), C++ (unlimited length, so have problems with followed digits) and Rust (limited range of representable characters -- only[0x00; 0x7f]).Seriously, who decided that using octal escape sequences by default was a good idea?
I've checked all languages and everything (except Java and Rust) are support
\xHHform.