Implement TlsPacket

[serega6531]

I've implemented TlsPacket for my personal use. It includes support for all types of TLS records, most frequently used handshake types, and key_share extension. It is very easy to add support for new handshake types.

Unfortunately, I couldn't create a test for it because for some reason there were no PacketFactoryBinders during tests run, but I tested it manually.

[serega6531]

It seems the build failed because Java 6 is required. Is this really necessary? Even the README.md says "Download and install JDK 9, 10, or 11"

[wo4wangle]

I've implemented TlsPacket for my personal use. It includes support for all types of TLS records, most frequently used handshake types, and key_share extension. It is very easy to add support for new handshake types.

Unfortunately, I couldn't create a test for it because for some reason there were no PacketFactoryBinders during tests run, but I tested it manually.

Hi serega6531, I really need to use TLS packet now in my work, could you take some time to fix it then success merged to maven? so much Thks!!!

[serega6531]

I guess I'll have to remove diamond brackets after all.

[serega6531]

Now it's up to @kaitoy

[coveralls]

Coverage increased (+0.3%) to 70.107% when pulling 1b6c01f on serega6531:tls into 0b4fad8 on kaitoy:v1.

[wo4wangle]

Now it's up to @kaitoy
Thank you for taking the time to help me, it really meant a lot!
it failed at coverage decreased.
cannot wait to try it.

[serega6531]

I'll try to add some tests

[wo4wangle]

I'll try to add some tests

I have informed kaitoy in all ways, but he seems very busy recently
could I ask you for some skill with Pcap4J?
I want to dump .pcap file with limited size (i.e. 100M), but do not how to implement it better.
I have read all example and most of pacap4j.core, however still can not find a solution, are you have some idea with it?thks!

[serega6531]

I'll try to add some tests

I have informed kaitoy in all ways, but he seems very busy recently
could I ask you for some skill with Pcap4J?
I want to dump .pcap file with limited size (i.e. 100M), but do not how to implement it better.
I have read all example and most of pacap4j.core, however still can not find a solution, are you have some idea with it?thks!

Check for file size after dumping each packet, maybe? And if it's > 100 Mb, create a new dumper.

[wo4wangle]

I'll try to add some tests

I have informed kaitoy in all ways, but he seems very busy recently
could I ask you for some skill with Pcap4J?
I want to dump .pcap file with limited size (i.e. 100M), but do not how to implement it better.
I have read all example and most of pacap4j.core, however still can not find a solution, are you have some idea with it?thks!

Check for file size after dumping each packet, maybe? And if it's > 100 Mb, create a new dumper.
thanks for your hint, I thought there is built-in api for it, but probably not
BTW, kaitoy said he would check your pr this weekend.

[serega6531]

BTW, kaitoy said he would check your pr this weekend.

Looking forward to it.