Skip to content

Set aria-live attribute to 'assertive' for playkit-subtitles element#408

Open
joaalto wants to merge 1 commit intokaltura:masterfrom
Yleisradio:subtitles-aria-live
Open

Set aria-live attribute to 'assertive' for playkit-subtitles element#408
joaalto wants to merge 1 commit intokaltura:masterfrom
Yleisradio:subtitles-aria-live

Conversation

@joaalto
Copy link

@joaalto joaalto commented Oct 15, 2019

Description of the Changes

After this screen readers will read the subtitles then they are updated.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

… so that screen readers will read the subtitles then they are updated.
@joaalto
Copy link
Author

joaalto commented Oct 15, 2019

Ping @OrenMe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant