fix(SUP-51539): Audio Descriptions enable and disable are reversed#862
fix(SUP-51539): Audio Descriptions enable and disable are reversed#862SivanA-Kaltura wants to merge 10 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect Audio Description (AD) identification by changing the mapping between AudioTracks and metadata.audioFlavors from index-based to label-based comparison, to prevent mismatched AD toggling when ordering differs.
Changes:
- Replaced index-based
audioFlavors[audioTracksIndex]matching with a label-based lookup viaaudioFlavors.find(...). - Updated AD detection and label-adjustment logic to use the matched flavor object.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of the Changes
Matching of audio track to audio flavor relies on indexing. In case the index does not match, we don't assign the correct flavor to the correct track, so another track will be identified as audio description when it actually isn't.
Solution - compare labels instead of using indexes.
Resolves SUP-51539