Fix SIGWINCH Crash on Windows#19
Merged
kamilmac merged 1 commit intokamilmac:mainfrom May 25, 2025
afunyun:SIGWINCH-windows-fix
Merged
Fix SIGWINCH Crash on Windows#19kamilmac merged 1 commit intokamilmac:mainfrom afunyun:SIGWINCH-windows-fix
kamilmac merged 1 commit intokamilmac:mainfrom
afunyun:SIGWINCH-windows-fix
Conversation
Contributor
Author
|
Of course! I just saw this repo from a reddit post last night and thought it looked sweet, was hype to try it only to get that error display, so when I searched and saw how small the fix was I was like yep i can't leave it lol. Cool project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Introduces a change to the
src/store/main.ts,such that signal listeners resizing the console (SIGWINCH) are added on non-Windows platforms, but it's ignored on Windows since it crashes Deno as that is not expected in a Windows env.src/store/main.tsCompiles just fine, ran