Move GLSL's current fixed 8-colour gradient system to temporary sampler1D texture generated at runtime.#756
Draft
ninetailedtori wants to merge 2 commits intokarlstav:masterfrom
Draft
Conversation
…system over to a sampler1D texture for efficient and expandable gradient support in our GLSL shaders. An example conversion is done in bar_spectrum.frag. This is done by temp generation of a gradient colour which is then cleaned up after program doesn't need it any further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on moving the GLSL shader method itself to generate a temp texture based on the current config structure of setting the gradient_count, then listing the colours as gradient_color_n.
This is then efficiently polled for its 1D coordinate against 0.0–1.0, which then gives us our accurate colour to use in gradient. This works a lot better when using it in shaders as well, but more usefully, allows us to expand the hard-coded 8 colours of gradient to something variable. I welcome any testing on this! Still working on the moving all shaders over, so I can test them all :]