Skip to content

changed str in str | os.pathlike#1328

Closed
edwijk365 wants to merge 4 commits intokedro-org:mainfrom
edwijk365:doc/update-json-ds-docstring
Closed

changed str in str | os.pathlike#1328
edwijk365 wants to merge 4 commits intokedro-org:mainfrom
edwijk365:doc/update-json-ds-docstring

Conversation

@edwijk365
Copy link
Copy Markdown

Description

issue 1317

Development notes

As a document change this is not tested

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@ravi-kumar-pilla ravi-kumar-pilla self-requested a review February 27, 2026 17:26
@ravi-kumar-pilla
Copy link
Copy Markdown
Contributor

ravi-kumar-pilla commented Feb 27, 2026

Hi @edwijk365 ,

Thank you for the contribution. We have a test for validating the PR title. Can you rename the title to something like - chore(datasets): update json dataset filepath type ?

And I see a DCO failure. Please sign off your commits. More info here - https://github.com/kedro-org/kedro/wiki/Guidelines-for-contributing-developers#developer-certificate-of-origin

Thank you

@ravi-kumar-pilla
Copy link
Copy Markdown
Contributor

Closing this in favor of - #1324
Thanks for contributing @edwijk365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants