Skip to content

docs(datasets): update type annotation polars#1330

Merged
merelcht merged 3 commits intokedro-org:mainfrom
jorisvane:ossprint/1317-polars
Feb 27, 2026
Merged

docs(datasets): update type annotation polars#1330
merelcht merged 3 commits intokedro-org:mainfrom
jorisvane:ossprint/1317-polars

Conversation

@jorisvane
Copy link
Copy Markdown
Contributor

@jorisvane jorisvane commented Feb 27, 2026

Description

This PR was done to complete a subtask of Issue #1317. This PR focusses on the Polars dataset.

Development notes

I updated the filepath type of the classes on the Polars dataset.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@jorisvane jorisvane changed the title Ossprint/1317 polars docs(datasets): updated type annotation polars Feb 27, 2026
@jorisvane jorisvane force-pushed the ossprint/1317-polars branch 2 times, most recently from ed75c73 to bfc05ba Compare February 27, 2026 17:48
- Add os.PathLike type to filepath in CSVDataset, EagerPolarsDataset, LazyPolarsDataset
- Update docstrings to mention path-like objects (e.g. pathlib.Path)
- Add os import where needed; remove duplicate import in lazy_polars_dataset

Made-with: Cursor
Signed-off-by: jorisvane <jorisvane@gmail.com>
@jorisvane jorisvane force-pushed the ossprint/1317-polars branch from 7101c5a to 531dde5 Compare February 27, 2026 17:52
@ravi-kumar-pilla ravi-kumar-pilla self-requested a review February 27, 2026 17:59
@jorisvane jorisvane changed the title docs(datasets): updated type annotation polars docs(datasets): update type annotation polars Feb 27, 2026
@merelcht merelcht self-assigned this Feb 27, 2026
Copy link
Copy Markdown
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jorisvane 🎉

@merelcht merelcht requested a review from lrcouto February 27, 2026 18:36
Copy link
Copy Markdown
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jorisvane 💯

@merelcht merelcht removed their assignment Feb 27, 2026
@merelcht merelcht enabled auto-merge (squash) February 27, 2026 18:38
Copy link
Copy Markdown
Contributor

@lrcouto lrcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you, @jorisvane !

Copy link
Copy Markdown
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jorisvane!

@merelcht merelcht merged commit f40ff60 into kedro-org:main Feb 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants