feat(datasets): Shorten pyproject.toml extra names for langfuse, opik, and langchain datasets#1365
feat(datasets): Shorten pyproject.toml extra names for langfuse, opik, and langchain datasets#1365ElenaKhaustova wants to merge 32 commits intomainfrom
pyproject.toml extra names for langfuse, opik, and langchain datasets#1365Conversation
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
…aluation-dataset-bu
Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
SajidAlamQB
left a comment
There was a problem hiding this comment.
Thank you @ElenaKhaustova!
|
The shorter names look good but I'm worried it strays from the convention we have set for the dependencies - the dataset after all is called |
Yes, that is a valid point, and I think we should also rename And I see the following pros for renaming:
So we probably should either rename both dependencies and datasets or leave them as is. My question: do you think it's worth it? @merelcht, @ankatiyar |
|
Ideally I also like the dataset names to be Since these are experimental datasets, we could update the names (with or without a deprecation warning, but for user experience aliasing might be good). We would also have to update the projects in |
|
I was thinking about this too, thanks for raising it @ankatiyar. I think we should take the benefit of these being experimental and just doing the rename without a transition period. Normally I would definitely be against that, but the whole point of these being experimental is that we're allowing slightly less solid datasets to be released and therefore breaking changes can happen while polishing the datasets between releases. As an extra check we can have a look at telemetry to see if many people are using these datasets and make a decision based on that if we see adoption is already high. |
Description
Context: #1347 (comment)
Development notes
langfuse-langfusepromptdataset → langfuse-promptdataset), making install commands shorter and more consistent with other extras.*Test plan
kedro-datasets[langfuse-promptdataset]resolves correctlykedro-datasets[langfuse]still installs all langfuse depsDeveloper Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
jsonschema/kedro-catalog-X.XX.jsonif necessaryRELEASE.mdfile