Parse additional fields in claim segment#15
Open
lrpauley wants to merge 2 commits intokeiron-stoddart:mainfrom
Open
Parse additional fields in claim segment#15lrpauley wants to merge 2 commits intokeiron-stoddart:mainfrom
lrpauley wants to merge 2 commits intokeiron-stoddart:mainfrom
Conversation
lrpauley
commented
Sep 12, 2022
|
|
||
| datum = { | ||
| 'marker': claim.claim.marker, | ||
| 'payer_claim_control_number': claim.claim.payer_claim_control_number if claim.claim else None, |
Author
There was a problem hiding this comment.
i'm not currently using the pandas integration, but if folks have opinions on which of the additional fields belong in the pandas output i'm happy to make changes. i added this field mostly to validate that the parser's output was still correct
lrpauley
commented
Sep 12, 2022
| self.payer_claim_control_number = get_element(segment, 7) | ||
| self.facility_type_code = get_element(segment, 8) | ||
| self.claim_frequency_code = get_element(segment, 9) | ||
| self.drg_code = get_element(segment, 11) |
Author
There was a problem hiding this comment.
i'd started to put together some unit tests for the claim segment parsing, but wanted to gauge interest before introducing a new approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing for additional fields in the claim segment (based on #8):