-
Notifications
You must be signed in to change notification settings - Fork 638
feat: error handling on ticks #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
616bb08
`feat`: add error handling
JosephVoid 8a24489
`feat`: added `errorHandler` function in `CronJobParams`
JosephVoid 255ce7f
`test`: added two more test cases
JosephVoid 4417117
`docs`: added API description
JosephVoid 1870cdd
`fix`: types
JosephVoid 5076e99
`test`: improve tests
JosephVoid 9b2cc1b
`fix`: applied fix based on suggestions
JosephVoid 98be5fe
`fix`: moved error handler to BaseCronJobParams
JosephVoid 7ae4cca
`fix`: put back the run time exception check
JosephVoid f13aba2
`test`: check errorHandler is called with the exception + fix case typo
sheerlox 1d1b9f7
Merge branch 'main' into feature/error-handling
intcreator e2662ca
restore table of contents
intcreator afc3cf6
spaaaaaaaaaaaaaaaaaaaaaace
intcreator 3ad88e5
Merge branch 'main' into feature/error-handling
sheerlox 5126162
Merge branch 'main' into feature/error-handling
intcreator 2891f16
Merge branch 'main' into feature/error-handling
intcreator 21cb4a6
update test to expect a console error since that's what happens
intcreator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.