Skip to content

build: migrate eslint config to flat style#913

Merged
intcreator merged 4 commits intomainfrom
intcreator/eslint-config
Nov 12, 2024
Merged

build: migrate eslint config to flat style#913
intcreator merged 4 commits intomainfrom
intcreator/eslint-config

Conversation

@intcreator
Copy link
Copy Markdown
Collaborator

@intcreator intcreator commented Nov 11, 2024

Description

Migrate .eslintrc to esling.config.mjs. Using .mjs so I can use import (.ts configs are still experimental). Fixed a few lint issues that were easy, changed one new lint rule to a warn since it wasn't caught before.

Related Issue

Fixes #899

Motivation and Context

Using the new flat config for Eslint is required for upgrading to 9.0

How Has This Been Tested?

Ran npm run lint and VS Code Eslint plugin many times

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@intcreator intcreator requested a review from sheerlox November 11, 2024 06:51
@intcreator intcreator force-pushed the intcreator/eslint-config branch from 5e7f069 to 9dd53d6 Compare November 11, 2024 06:51
@intcreator intcreator changed the title Intcreator/eslint config build: migrate eslint config to flat style Nov 11, 2024
@intcreator
Copy link
Copy Markdown
Collaborator Author

intcreator commented Nov 11, 2024 •
edited
Loading

looks like this won't be able to be merged until we drop support for Node v16

edit: I was able to support Node v16 by downgrading typescript-eslint

@intcreator intcreator force-pushed the intcreator/eslint-config branch from 9dd53d6 to 44be35b Compare November 12, 2024 02:50
@intcreator intcreator force-pushed the intcreator/eslint-config branch from bc3f362 to 69ff9e9 Compare November 12, 2024 02:58
@intcreator intcreator merged commit 38c1044 into main Nov 12, 2024
@intcreator intcreator deleted the intcreator/eslint-config branch November 12, 2024 16:55
@ncb000gt
Copy link
Copy Markdown
Member

ncb000gt commented Nov 12, 2024

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

intcreator pushed a commit that referenced this pull request Nov 12, 2024
@semantic-release-bot
Release v3.2.1 [skip ci]
441b4a2 
## [3.2.1](v3.2.0...v3.2.1) (2024-11-12)

### 🛠 Builds

* migrate eslint config to flat style ([#913](#913)) ([38c1044](38c1044)), closes [#899](#899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheerlox sheerlox sheerlox approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update .eslintrc to eslint.config.js name/format

3 participants

@intcreator @ncb000gt @sheerlox