Skip to content

docs(contributing): add "Submitting a Pull Request" & "Coding Rules" sections#936

Merged
intcreator merged 3 commits intokelektiv:mainfrom
sheerlox:docs/fix-contributing-link
Dec 30, 2024
Merged

docs(contributing): add "Submitting a Pull Request" & "Coding Rules" sections#936
intcreator merged 3 commits intokelektiv:mainfrom
sheerlox:docs/fix-contributing-link

Conversation

@sheerlox
Copy link
Copy Markdown
Collaborator

Description

Initially just wanted to update the broken "Working with the code" link, but you know, once you've opened a file ... 🥲

Related Issue

Motivation and Context

Missing useful sections.

How Has This Been Tested?

Manually tested all self-referencing links.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added the type:docs Improvements or additions to documentation label Dec 29, 2024
@sheerlox sheerlox requested a review from intcreator December 29, 2024 14:56
@intcreator intcreator merged commit ddd8988 into kelektiv:main Dec 30, 2024
@sheerlox sheerlox deleted the docs/fix-contributing-link branch December 30, 2024 17:45
@ncb000gt
Copy link
Copy Markdown
Member

ncb000gt commented Jan 9, 2025

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sheerlox pushed a commit that referenced this pull request Jan 9, 2025
## [3.4.0](v3.3.2...v3.4.0) (2025-01-09)

### ✨ Features

* error handling on ticks ([#861](#861)) ([0d3161f](0d3161f)), closes [#426](#426)

### 📚 Documentation

* **contributing:** add "Submitting a Pull Request" & "Coding Rules" sections ([#936](#936)) ([ddd8988](ddd8988))

### ♻️ Chores

* **deps:** lock file maintenance ([494b4bf](494b4bf))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.11 ([2978e92](2978e92))
* **deps:** update dependency lint-staged to v15.3.0 ([11f9bad](11f9bad))
* **deps:** update semantic-release related packages ([b830bdb](b830bdb))
* **deps:** update tests (major) ([#826](#826)) ([e47fd5a](e47fd5a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released type:docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants