refactor!: drop support for Node v16 and rename job.running to job.isActive#957
Merged
intcreator merged 4 commits intomainfrom Feb 19, 2025
Merged
refactor!: drop support for Node v16 and rename job.running to job.isActive#957intcreator merged 4 commits intomainfrom
intcreator merged 4 commits intomainfrom
Conversation
BREAKING CHANGE: Node 16 is no longer supported ## Description ## Related Issue ## Motivation and Context  ## How Has This Been Tested? ## Screenshots (if appropriate): ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [X] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [X] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
Collaborator
Author
|
couple things; looks like the Lint PR title is just having a weird error right now? so we might have to wait for that to clear up. also if there's anything breaking from #674 you might want to throw into this branch let me know |
sheerlox
reviewed
Feb 18, 2025
sheerlox
reviewed
Feb 18, 2025
Collaborator
looks like that was from GitHub, re-running fixed it (never seen this one before lol). regarding #674 nothing urgent, so I ain't really got the time to dedicate to those rn, maybe later 😉 expect for the comments I left, lgtm! P.S. tag me on Discord when I need to approve again, I might miss you otherwise |
sheerlox
previously approved these changes
Feb 18, 2025
Member
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WillianAgostini
pushed a commit
to WillianAgostini/node-cron
that referenced
this pull request
Feb 19, 2025
## [4.0.0](kelektiv/node-cron@v3.5.0...v4.0.0) (2025-02-19) ### ⚠ Breaking changes * drop support for Node v16 and rename job.running to job.isActive (kelektiv#957) ### 📦 Code Refactoring * drop support for Node v16 and rename job.running to job.isActive ([kelektiv#957](kelektiv#957)) ([605e94e](kelektiv@605e94e)), closes [kelektiv#902](kelektiv#902) [kelektiv#905](kelektiv#905) ### ♻️ Chores * **action:** update actions/checkout action to v4.2.2 ([kelektiv#927](kelektiv#927)) ([ff1721e](kelektiv@ff1721e)) * **action:** update actions/setup-node action to v4.1.0 ([kelektiv#928](kelektiv#928)) ([3e27773](kelektiv@3e27773)) * **action:** update actions/upload-artifact action to v4.6.0 ([kelektiv#931](kelektiv#931)) ([8283000](kelektiv@8283000)) * **action:** update amannn/action-semantic-pull-request action to v5.5.3 ([kelektiv#929](kelektiv#929)) ([f1851d7](kelektiv@f1851d7)) * **action:** update github/codeql-action action to v3.28.1 ([kelektiv#922](kelektiv#922)) ([eefd476](kelektiv@eefd476)) * **deps:** lock file maintenance ([c3af5fc](kelektiv@c3af5fc)) * **deps:** lock file maintenance ([d689a1c](kelektiv@d689a1c)) * **renovate:** improve schedules & automerging to reduce noise ([kelektiv#942](kelektiv#942)) ([c253032](kelektiv@c253032))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
job.runninghas been renamed tojob.isActiveDescription
Related Issue
fixes #902
fixes #905
Motivation and Context
How Has This Been Tested?
Tests have been updated to use new API and all pass. Fuzz tests also pass.
Screenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).