feat!: remove child_process dependency for browser compatibility#968
feat!: remove child_process dependency for browser compatibility#968intcreator merged 2 commits intokelektiv:v5from
child_process dependency for browser compatibility#968Conversation
BREAKING CHANGE: Removed the ability to execute system commands using string-based inputs. This eliminates the dependency on `child_process`, improving browser compatibility. Users relying on this functionality should migrate to executing commands manually within their own implementations. kelektiv#967
|
just want to give an update on this, I'm holding off for now because this would require a major version change and we just released a major version. at the very least I would like to bundle one other breaking change I've been meaning to make for a v5 release, which is deprecating the arguments list constructor in favor of only using a single object argument constructor |
|
Can this be released as beta/alfa node module to test out? Update: |
|
@Faq It is very likely an issue on your end as this PR doesn't include any reference to @intcreator @sheerlox This PR is really needed to improve readability and usability of the project. I just started using
|
|
@Faq my goal is to release a beta version on a v5 branch today @Elliot67 the reason this PR will fix the issue is because it will allow this library to be used in the browser, which is currently prevented by cron depending on Node.js functionality my plan is to:
while not explicitly documented, the functionality is mentioned in the documentation and it is intended functionality, so it merits a major version change in case people are relying on it working as is. |
|
published to 5.0.0-beta.1: https://www.npmjs.com/package/cron/v/5.0.0-beta.1 I'll give it a couple of days for the testers to poke and then I should be ready to release a major v5 release |
|
53 downloads in the last few days. no complaints so far that I can see |
Description
BREAKING CHANGE: Removed the ability to execute system commands using string-based inputs. This eliminates the dependency on
child_process, improving browser compatibility. Users relying on this functionality should migrate to executing commands manually within their own implementations.Related Issue
#967
Motivation and Context
Running node-cron in a browser-based environment.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).