feat: Allow awaiting job.stop()#977
Merged
intcreator merged 2 commits intokelektiv:mainfrom Apr 14, 2025
ehooi:allow-awaiting-stop
Merged
feat: Allow awaiting job.stop()#977intcreator merged 2 commits intokelektiv:mainfrom ehooi:allow-awaiting-stop
intcreator merged 2 commits intokelektiv:mainfrom
ehooi:allow-awaiting-stop
Conversation
intcreator
approved these changes
Apr 14, 2025
Collaborator
intcreator
left a comment
intcreator
left a comment
There was a problem hiding this comment.
haha short diffs are the best diffs
Collaborator
|
closes #976 |
Member
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
intcreator
pushed a commit
that referenced
this pull request
Apr 15, 2025
## [4.2.0](v4.1.4...v4.2.0) (2025-04-14) ### ✨ Features * Allow awaiting job.stop() ([#977](#977)) ([e296b76](e296b76)), closes [#976](#976) ### ♻️ Chores * **action:** update github/codeql-action action to v3.28.15 ([baf9c7e](baf9c7e)) * **action:** update marocchino/sticky-pull-request-comment action to v2.9.2 ([#975](#975)) ([df57bef](df57bef)) * **action:** update step-security/harden-runner action to v2.11.1 ([da1764d](da1764d)) * **deps:** lock file maintenance ([c37a3ec](c37a3ec)) * **deps:** lock file maintenance ([#979](#979)) ([6a355a3](6a355a3)) * **deps:** pin dependencies ([6ddc31e](6ddc31e)) * **deps:** update dependency [@fast-check](https://github.com/fast-check)/jest to v2.1.1 ([3fa6836](3fa6836)) * **deps:** update dependency [@swc](https://github.com/swc)/core to v1.11.18 ([00d0685](00d0685)) * **deps:** update dependency [@types](https://github.com/types)/node to v22.14.0 ([7dedc90](7dedc90)) * **deps:** update dependency sinon to v19.0.5 ([448934c](448934c)) * **deps:** update dependency sinon to v20 ([#974](#974)) ([ac25eff](ac25eff)) * **deps:** update dependency typescript to v5.8.3 ([7b583a4](7b583a4)) * **deps:** update linters ([#978](#978)) ([cdb638a](cdb638a)) * **deps:** update node.js to v23.11.0 ([#973](#973)) ([7d457cf](7d457cf))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe this would be useful for building a job manager (see: #871)
and supporting graceful shutdown (see: #713).
Related Issue
#976
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).