Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of
Resize()view, when in certain scenarios the subscribers weren't properly updated (either subscribe or unsubscribe). Also Rect API has changed, it is now exclusive of the bottom-right boundary to align with more widely adopted approaches.View Enhancements:
Viewfunctionality by adding aMoveTomethod and refining theResizemethod to handle view changes more efficiently inview.go.view_test.goto include new test cases forMoveToand adjusted existing tests to reflect changes inViewbehavior. [1] [2] [3]Rect Enhancements:
RectAPI by modifyingContains,Intersects, andSizemethods to be value receivers and added new methods likeIsZeroandDifferencefor better rectangle operations inpoint.go.WithinandWithinRectmethods ofPointto utilize the newRectmethods.Dependency Updates:
github.com/kelindar/iostreamto v1.4.0 andgitlite.zycloud.tk/stretchr/testifyto v1.9.0 ingo.mod.