Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions spec/base_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,20 @@ describe "Session" do
end
end

describe "cookie" do
it "should create a cookie with the samesite set to strict" do
Kemal::Session.config do |config|
config.cookie_name = "woops"
config.samesite = HTTP::Cookie::SameSite::Strict
end

context = create_cookie_context(SESSION_ID, Kemal::Session.config)
session = Kemal::Session.new(context)
cookie = context.response.cookies[Kemal::Session.config.cookie_name]
cookie.samesite.should eq(HTTP::Cookie::SameSite::Strict)
end
end

describe "signed cookies" do
signed_session = "#{SESSION_ID}--#{Kemal::Session.sign_value(SESSION_ID)}"

Expand Down
12 changes: 12 additions & 0 deletions spec/spec_helper.cr
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ def create_context(session_id : String)
return HTTP::Server::Context.new(request, response)
end

def create_cookie_context(session_id : String, session)
response = HTTP::Server::Response.new(IO::Memory.new)
headers = HTTP::Headers.new

session.engine.create_session(session_id)
cookies = HTTP::Cookies.new
cookies << HTTP::Cookie.new(Kemal::Session.config.cookie_name, Kemal::Session.encode(session_id))
cookies.add_request_headers(headers)
request = HTTP::Request.new("GET", "/", headers)
return HTTP::Server::Context.new(request, response)
end

macro expect_not_raises(file = __FILE__, line = __LINE__)
%failed = false
begin
Expand Down
1 change: 1 addition & 0 deletions src/kemal-session/base.cr
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ module Kemal
secure: Session.config.secure,
path: Session.config.path,
domain: Session.config.domain,
samesite: Session.config.samesite
)
end

Expand Down
5 changes: 4 additions & 1 deletion src/kemal-session/config.cr
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ module Kemal
@secure : Bool
@domain : String?
@path : String
property timeout, gc_interval, cookie_name, engine, secret, secure, domain, path
@samesite : Cookie::SameSite?
property timeout, gc_interval, cookie_name, engine, secret, secure, domain, path, samesite

def engine=(e : Engine)
@engine = e
Expand All @@ -26,6 +27,7 @@ module Kemal
@secure = false
@domain = nil
@path = "/"
@samesite = nil
end
end # Config

Expand All @@ -37,4 +39,5 @@ module Kemal
Config::INSTANCE
end
end # Session
include HTTP
end