Merged
Conversation
baa8377 to
7084a18
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 14 changed files in this pull request and generated 1 comment.
Files not reviewed (13)
- board/common/mkdisk.sh: Language not supported
- board/common/post-image.sh: Language not supported
- board/common/qemu/qemu.sh: Language not supported
- board/common/rootfs/usr/libexec/infix/init.d/30-cfg-migrate: Language not supported
- test/env: Language not supported
- test/qeneth: Language not supported
- test/templates/inc/infix-disk.mustache: Language not supported
- test/templates/inc/infix-usb.mustache: Language not supported
- test/templates/infix-bios-x86_64.mustache: Language not supported
- test/templates/infix-kernel-x86_64.mustache: Language not supported
- test/templates/infix-x86_64.mustache: Language not supported
- test/test.mk: Language not supported
- test/virt/quad/topology.dot.in: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:149
- The checksum generation block uses '*.qcow2' which might not detect files if they are stored in a subdirectory (e.g. 'output/images/') as defined in the artifact upload step. Ensure the file path is consistent throughout the workflow.
if ls *.qcow2 &>/dev/null; then
This make the release bundle much smaller, the disk image size change from 512M to 2xsizeof(squashimage)
This to make it easier to use GNS3 appliance file from GNS3 marketplace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed image type from RAW to qcow2
Also:
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: