Start tracking until it goes zero#182
Closed
kevincobain2000 wants to merge 1 commit intofeature/golangci-lintfrom
Closed
Start tracking until it goes zero#182kevincobain2000 wants to merge 1 commit intofeature/golangci-lintfrom
kevincobain2000 wants to merge 1 commit intofeature/golangci-lintfrom
Conversation
kevincobain2000
changed the base branch from
master
to
feature/golangci-lint
Merged
CoverItUp Report
|
kevincobain2000
commented
Feb 10, 2024
| echo SCORE=$(($SECONDS-BUILD_START)) >> "$GITHUB_ENV" | ||
| shell: bash | ||
|
|
||
| - name: Lint Errors |
Owner
Author
There was a problem hiding this comment.
ah yes and I removed the separate workflow file.
Once we have zero counts on the lint, will update this CI to exit 1 upon any errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this linter TBH. In my company we have started using it too.
Reason for this pull request is because
I looked at the errors produced by the linter. It is a half day job to fix the errors. I don't think we are going to be fixing the lint errors anytime soon. However, we can still add the linter and at least start tracking the counts to go down.