refactor: simplify Go version logic with centralized VersionManager#223
Merged
kevincobain2000 merged 2 commits intomasterfrom Oct 3, 2025
Merged
refactor: simplify Go version logic with centralized VersionManager#223kevincobain2000 merged 2 commits intomasterfrom
kevincobain2000 merged 2 commits intomasterfrom
Conversation
- Extract complex version handling logic into dedicated VersionManager struct - Replace 100+ line judgeVersion function with focused, testable methods - Use consistent semver library parsing for better reliability - Eliminate recursive calls and nested conditions - Improve error handling with proper validation - Add comprehensive version resolution methods for different patterns - Maintain backward compatibility with existing API - Update test expectations to match corrected version resolution - Clean up unused imports and fix compilation warnings
Collaborator
Author
|
@kevincobain2000 whats wrong with windows checks? |
kevincobain2000
approved these changes
Oct 2, 2025
Owner
Probably action issue and not gobrew issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version management logic has been simplified.