fix(qfwin): add nil check for object in winleave autocmd#120
Open
Subjective wants to merge 2 commits intokevinhwang91:mainfrom
Open
fix(qfwin): add nil check for object in winleave autocmd#120Subjective wants to merge 2 commits intokevinhwang91:mainfrom
Subjective wants to merge 2 commits intokevinhwang91:mainfrom
Conversation
shubhampaul
suggested changes
Nov 8, 2023
shubhampaul
left a comment
shubhampaul
left a comment
There was a problem hiding this comment.
I would suggest you to not change more than what is required. In this case case changing quotes from single to double. Not only does it add unnecessary diffs but in this case it also changes the coding style from rest of the project (if you observe the quotes in other lua files).
Contributor
Author
|
@shubhampaul Yeah I had the wrong formatter set, it should be fixed now. |
kevinhwang91
reviewed
Nov 9, 2023
| @@ -92,7 +92,9 @@ function QfSession:saveWinView(winid) | |||
| if winid then | |||
| local obj = self.pool[winid] | |||
| local wv = utils.winCall(winid, fn.winsaveview) | |||
Owner
There was a problem hiding this comment.
winsaveview should be invoked after checking the nil condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108