This repository was archived by the owner on Feb 12, 2019. It is now read-only.
vendor: update go-git to master and add push optimizations#1127
Merged
vendor: update go-git to master and add push optimizations#1127
Conversation
strib
force-pushed
the
strib/KBFS-2354-git-push
branch
from
b716003 to
9e5afc8
Compare
strib
force-pushed
the
strib/better-gogit-push-perf
branch
from
f3fb7e6 to
b64aafd
Compare
strib
force-pushed
the
strib/KBFS-2354-git-push
branch
from
9e5afc8 to
1c0b18a
Compare
strib
force-pushed
the
strib/better-gogit-push-perf
branch
2 times, most recently
from
559c905 to
51661a5
Compare
songgao
approved these changes
Aug 28, 2017
Compared to the v4 branch we were using before, master branch seems to fix a few bugs and bring the time for pushing the KBFS repo from hours to about 25 minutes. With the following optimizations, I got that time down to less than 3 minutes. * src-d/go-git#564 * src-d/go-git#565 I suspect there are still lots more optimizations that can be done. I don't think there are many users of Push in this project.
Now that PRs are merged. Issue: KBFS-2384
strib
force-pushed
the
strib/better-gogit-push-perf
branch
from
51661a5 to
35d69e5
Compare
jzila
approved these changes
Aug 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to the v4 branch we were using before, master branch seems to
fix a few bugs and bring the time for pushing the KBFS repo from hours
to about 25 minutes. With the following optimizations, I got that
time down to less than 3 minutes.
seenmap in tree walker src-d/go-git#564I suspect there are still lots more optimizations that can be done. I
don't think there are many users of Push in this project.