feat(web): add dedicated quotient-spur type for insertion edits 🚂#15714
Open
jahorton wants to merge 3 commits intofeat/web/substitution-spursfrom
Open
feat(web): add dedicated quotient-spur type for insertion edits 🚂#15714jahorton wants to merge 3 commits intofeat/web/substitution-spursfrom
jahorton wants to merge 3 commits intofeat/web/substitution-spursfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
2 times, most recently
from
1183bcc to
360c0ae
Compare
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
from
ad8e65e to
75424c2
Compare
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
from
360c0ae to
ac58138
Compare
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
2 times, most recently
from
4c18f94 to
8b1abf7
Compare
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
2 times, most recently
from
cfc8d96 to
816fac7
Compare
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
from
8b1abf7 to
2234fd7
Compare
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
from
816fac7 to
adcb188
Compare
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
from
feb44cf to
9bd0afa
Compare
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
from
adcb188 to
7d2544f
Compare
jahorton
commented
Apr 17, 2026
Comment on lines
+391
to
+399
| // We triggered the processing of this node from our parent | ||
| // quotient-node, so that parent cannot report this result. | ||
| // | ||
| // If `this` node models insertion spurs, then the result is | ||
| // valid for this node's keystroke count too - and thus should | ||
| // be forwarded as a potential correction-search result. | ||
| if(this.inputCount == this.parentNode.inputCount) { | ||
| return result; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
TODO: remove this. QuotientNodeFinalizer (per #15855) removes the need for it.
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
from
7d2544f to
ed05f68
Compare
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
from
9bd0afa to
c0d395f
Compare
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
from
2fd16c0 to
00f361b
Compare
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
from
c0d395f to
6abf417
Compare
jahorton
force-pushed
the
feat/web/substitution-spurs
branch
2 times, most recently
from
086713a to
77b22a2
Compare
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
feat/web/insertion-spurs
branch
from
6abf417 to
fb644ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip