Skip to content

chore(common): cleanup optionals in ldml keyboard reader #15865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcdurdin wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −10
Open

chore(common): cleanup optionals in ldml keyboard reader #15865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml-reader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,31 +100,31 @@ export class LDMLKeyboardXMLSourceFileReader implements EventResolver {
boxXmlArray(source?.keyboard3?.locales, 'locale');
boxXmlArray(source?.keyboard3, 'transforms');
if(source?.keyboard3?.layers) {
for(const layers of source?.keyboard3?.layers) {
for(const layers of source.keyboard3.layers) {
boxXmlArray(layers, 'layer');
if(layers?.layer) {
for(const layer of layers?.layer) {
if(layers.layer) {
for(const layer of layers.layer) {
boxXmlArray(layer, 'row');
}
}
}
}
if(source?.keyboard3?.forms?.form) {
boxXmlArray(source?.keyboard3?.forms, 'form');
for(const form of source?.keyboard3?.forms?.form) {
boxXmlArray(source.keyboard3.forms, 'form');
for(const form of source.keyboard3.forms.form) {
boxXmlArray(form, 'scanCodes');
}
}
if(source?.keyboard3?.flicks) {
boxXmlArray(source?.keyboard3?.flicks, 'flick');
for(const flick of source?.keyboard3?.flicks?.flick) {
boxXmlArray(source.keyboard3.flicks, 'flick');
for(const flick of source.keyboard3.flicks.flick) {
boxXmlArray(flick, 'flickSegment');
}
}
if(source?.keyboard3?.variables) {
boxXmlArray(source?.keyboard3?.variables, 'set');
boxXmlArray(source?.keyboard3?.variables, 'string');
boxXmlArray(source?.keyboard3?.variables, 'uset');
boxXmlArray(source.keyboard3.variables, 'set');
boxXmlArray(source.keyboard3.variables, 'string');
boxXmlArray(source.keyboard3.variables, 'uset');
}
if(source?.keyboard3?.transforms) {
for(const transforms of source.keyboard3.transforms) {
Expand Down
Loading