Open
Conversation
khud
reviewed
Aug 16, 2019
| "Unresolved reference: prinln", result.message().get(0).getData().trim()); | ||
| assertEquals("Unresolved reference: prinln", result.message().get(0).getData().trim()); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Add testCancel() and testRuntimeError() to check stderr is handled correctly
Owner
There was a problem hiding this comment.
Add KotlinSparkInterpreterTest to check spark related stuff
Collaborator
Author
There was a problem hiding this comment.
Add testCancel() and testRuntimeError() to check stderr is handled correctly
done
dkaznacheev
force-pushed
the
kotlin-spark-interpreter
branch
from
c1216f7 to
9e4d20b
Compare
dkaznacheev
force-pushed
the
kotlin-spark-interpreter
branch
2 times, most recently
from
5db1fa8 to
7936d0a
Compare
dkaznacheev
force-pushed
the
kotlin-spark-interpreter
branch
from
df25ddf to
ecd1f5d
Compare
# Conflicts: # .travis.yml # LICENSE
# Conflicts: # .travis.yml
ileasile
force-pushed
the
kotlin-spark-interpreter
branch
from
e6c4721 to
ad2c1a9
Compare
ileasile
pushed a commit
to ileasile/zeppelin
that referenced
this pull request
Jul 5, 2020
…ookRepo.java to allow it to work on windows
### What is this PR for?
The rootNotebookFolder variable in VFSNotebookRepo.java does not contain the root directory in windows. For e.g. if notebook directory is "C:/Users/zeppelin-notes", the value of rootNotebookFolder set in VFSNotebookRepo.java:91 is "/Users/zeppelin-notes", which is not found in windows and throws an exception at launch.
Using `this.rootNotebookFolder = rootNotebookFileObject.getName().getURI().replace("file:///", "/");` instead allows us to set the correct value for rootNotebookFolder (i.e. /C:/Users/zeppelin-notes).
Similarly, the noteFileName (VFSNotebookRepo.java:110) variable is missing root directory in windows and using `String noteFileName = fileObject.getName().getURI().replace("file:///", "/");` fixes this.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4574
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE SOFTWARE FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT VERSION R190612.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.
Author: Muhammad Taufiq <Muhammad.Taufiq@morganstanley.com>
Author: Muhammad-ms <59560973+Muhammad-ms@users.noreply.github.com>
Closes apache#3615 from Muhammad-ms/zeppelin9_vfs and squashes the following commits:
b0a65c0 [Muhammad Taufiq] [ZEPPELIN-4574] Added comments explaining the change
81b054e [Muhammad Taufiq] [ZEPPELIN-4574] Fixed rootNotebookFolder and noteFileName in VFSNotebookRepo.java to allow it to work on windows
4f532aa [Muhammad-ms] Merge pull request khud#1 from apache/master
ileasile
pushed a commit
to ileasile/zeppelin
that referenced
this pull request
Jul 5, 2020
…otePath variable for note title ### What is this PR for? The variable noteName does not contain leading "/", unlike notePath. Therefore, using former prevents the leading "/" from appearing in the note name displayed on Zeppelin page. ### What type of PR is it? Bug Fix ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4575 THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE SOFTWARE FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT VERSION R190612. THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS. Author: Muhammad-ms <59560973+Muhammad-ms@users.noreply.github.com> Author: Muhammad Taufiq <Muhammad.Taufiq@morganstanley.com> Closes apache#3616 from Muhammad-ms/zeppelin9_noteTitle and squashes the following commits: a3b79be [Muhammad Taufiq] [ZEPPELIN-4575] Switched to the use of noteName variable instead of notePath variable as it does not contain leading / 4f532aa [Muhammad-ms] Merge pull request khud#1 from apache/master
ileasile
pushed a commit
to ileasile/zeppelin
that referenced
this pull request
Jul 5, 2020
…a .war file ### What is this PR for? This PR disables the local extraction of zeppelin-web.war if ZEPPELIN_WAR is pointing to a .war file. This has 2 advantages: 1. Skipping WAR extraction improves Zeppelin launch time 2. It prevents any problems arising from the corruption of local zeppelin-web extraction ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4573 THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE SOFTWARE FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT VERSION R190612. THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS. Author: Muhammad-ms <59560973+Muhammad-ms@users.noreply.github.com> Author: Muhammad Taufiq <Muhammad.Taufiq@morganstanley.com> Closes apache#3614 from Muhammad-ms/zeppelin9_war_extraction and squashes the following commits: d01bdd2 [Muhammad Taufiq] [ZEPPELIN-4564] Disable zeppelin-web.war extraction when pointing to a .war file 4f532aa [Muhammad-ms] Merge pull request khud#1 from apache/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for code review