there is a space in the shell path，open session error

[bestv5]

If there is a space in the path, an error will be reported when opening the session。
such as ,
new a session, shelll panel, choose a gitbash shell , then this session config is:
{
"process.arguments" : "--login -i",
"process.workingDirectory" : "$(HomeDir)",
"session.icon" : "session::gitbash",
"session.label" : "gitbash",
"session.logOption" : 1,
"session.logType" : 0,
"session.protocol" : "Shell",
"session.system" : "linux",
"session.target" : "D:/Program Files/Git/bin/bash.exe",
"session.uuid" : "7b451d46-e762-42d4-8d45-b309c94aa37c",
"window.caretStyle" : "blinking line",
"window.mouseWheelScrollLines" : 1
}

when open this session , it can not open this session。
It looks like the path is caused by spaces.

OS ：win10
windterm version: 2.2.0 pre 4

[funkpopo]

My Git bash was installed with default settings but included Mingw64 for gcc. Maybe you need to re-check the "Session settings - Shell - Process" to add or edit the "Environment variables" based on your settings.
The target is "git-bash.exe" which lives in "../Program Files/Git/git-bash.exe".
Don't know whether my suggestion can help you or not, hope you can fix the problem soon.

[kingToolbox]

@bestv5
Sorry, I tested that everything is Okey and cannot reproduce this issue. Please give the content of the error message, or give a screenshot of the error. Thank you.

[wenbingzhang]

@kingToolbox
I can't set two parameters.

[kingToolbox]

I see, it looks like multiple parameters are causing the problem. I will investigate this issue and will update here if there are any progress. Thank you.

[kingToolbox]

I am happy to inform you that WindTerm_2.3.1 has been released and this issue has been fixed. Please download and check it. If there are still bugs, please let me know, thank you.

[wenbingzhang]

@kingToolbox

There is a small problem. Why is there an extra line?

[kingToolbox]

@wenbingzhang
I dont know. Can you collect the debug log for me for further analysis, if possible, the steps are as follows:

• Open your session.
• Click the Disconnect button on the toolbar to disconnect the session.
• Check the menu item Menubar - Mode (7) - Debug Mode.
• Click the Reconnect button on the toolbar or press the Return key to reconnect the session.
• Uncheck the menu item Menubar - Mode (7) - Debug Mode.
• Click the menu item Right click menu - Log - Open Log Folder.
• Open the folder debug and paste your log file in your comment here. You can zip it before upload.

The log content is in plain text and will not contain any private information. You can use any editor to view it. Thank you.

[wenbingzhang]

@kingToolbox
2022-02-23_13.42.35.log

Another problem was found, the window size was adjusted, and the number of rows changed.
https://user-images.githubusercontent.com/13162606/155267610-a27f339d-9cd8-43f4-84cd-04690f790baa.mov