fix: dispatch HealthKit callback continuations to main thread#327
Merged
robertherber merged 2 commits intokingstinct:masterfrom Mar 11, 2026
Merged
Conversation
commit: |
🦋 Changeset detectedLatest commit: 2cdec47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
debitan
force-pushed
the
fix/main-thread-continuation-resume
branch
from
97842e1 to
1076e61
Compare
HealthKit completion handlers fire on arbitrary background dispatch queues. When using Nitro Modules, resuming a Swift continuation from a background thread causes the JSI bridge to access the Hermes JS runtime from a non-main thread. Since Hermes is single-threaded and not thread-safe, this results in a SIGSEGV crash. Wrap all `continuation.resume(...)` calls inside HealthKit callbacks with `DispatchQueue.main.async` to ensure they execute on the main thread, consistent with the existing pattern in `subscribeToObserverQuery`. Affected files: - CoreModule.swift - Helpers.swift - ElectrocardiogramModule.swift - HeartbeatSeriesModule.swift - QuantityTypeModule.swift - WorkoutProxy.swift - WorkoutsModule.swift
debitan
force-pushed
the
fix/main-thread-continuation-resume
branch
from
1076e61 to
2cdec47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326
Summary
HealthKit completion handlers fire on arbitrary background dispatch queues. When using Nitro Modules, resuming a Swift continuation from a background thread causes the JSI bridge to access the Hermes JS runtime from a non-main thread, resulting in a SIGSEGV.
This PR wraps all
continuation.resume(...)calls inside HealthKit callbacks withDispatchQueue.main.async, consistent with the existing pattern insubscribeToObserverQueryandqueryStatisticsForQuantityInternal.Changes
7 files, all in
packages/react-native-healthkit/ios/:getRequestStatusForAuthorization,requestAuthorization,querySources,enableBackgroundDelivery,disableBackgroundDelivery,disableAllBackgroundDelivery,deleteObjects,getPreferredUnitsInternal)sampleAnchoredQueryAsync,sampleQueryAsync,saveAsync)getECGVoltages)getHeartbeatSeriesHeartbeats)queryStatisticsCollectionForQuantityInternal)getRouteLocations)startWatchAppWithWorkoutConfiguration,saveWorkoutSampleincluding nestedstore.addcallback)