Feature request: faster method of selecting high levels#118
Open
zohassadar wants to merge 1 commit intokirjavascript:masterfrom
Open
Feature request: faster method of selecting high levels#118zohassadar wants to merge 1 commit intokirjavascript:masterfrom
zohassadar wants to merge 1 commit intokirjavascript:masterfrom
Conversation
Owner
|
thanks for the PR! the code looks good, I think I just need to think a while on if the UX is ideal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing the crunch mode crash, I thought it would be nice to choose higher levels a bit faster. I had the idea of pressing right to add 10, but when going to add this feature to try it out I found there was precedent that was obviously not desired:
TetrisGYM/src/gamemode/levelmenu.asm
Line 259 in b499e7e
Instead, I tried out holding A to jump by 10 instead of 1. This required a slight modification to the menu throttle routine.